hynek / pem

PEM file parsing in Python.
https://pem.readthedocs.io/
MIT License
156 stars 37 forks source link

Added pem data #74

Closed spacemanspiff2007 closed 1 year ago

spacemanspiff2007 commented 1 year ago

Pull Request Check List

This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

spacemanspiff2007 commented 1 year ago

Closes #73

spacemanspiff2007 commented 1 year ago

how would you feel about adding a decoded_payload too?

Maybe use payload_raw and payload_bytes? Or rather payload_decoded?

hynek commented 1 year ago

I think payload_decoded is more precise/obvious, yes!

spacemanspiff2007 commented 1 year ago

Like this?

hynek commented 1 year ago

(I understand now why you put it into the breaking section :) – I kinda didn't consider the constructor to be a public API, but 101% someone somewhere is doing just that)

hynek commented 1 year ago

as a heads up: while making is compatible, I've decided the churn isn't worth it and switched to a lazy extraction in 0a9780a, I hope you can live with that.

spacemanspiff2007 commented 1 year ago

Yes - of course! Thanks for the heads up