Closed spacemanspiff2007 closed 1 year ago
Closes #73
how would you feel about adding a
decoded_payload
too?
Maybe use payload_raw
and payload_bytes
?
Or rather payload_decoded
?
I think payload_decoded
is more precise/obvious, yes!
Like this?
(I understand now why you put it into the breaking section :) – I kinda didn't consider the constructor to be a public API, but 101% someone somewhere is doing just that)
as a heads up: while making is compatible, I've decided the churn isn't worth it and switched to a lazy extraction in 0a9780a, I hope you can live with that.
Yes - of course! Thanks for the heads up
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.
docs/api.rst
by hand.versionadded
,versionchanged
, ordeprecated
directives. Find the appropriate next version in our__init__.py
file..rst
files is written using semantic newlines.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!