search

hynek / prometheus-async

Async Python helpers for the official prometheus-client.
https://prometheus-async.readthedocs.io/
Apache License 2.0
163 stars 15 forks source link

Micro optimizations for configs and code organization #3

Closed ashald closed 8 years ago

ashald commented 9 years ago

As you said in twitter, FWIW - I had nothing to do and was lazy enough to lay on my couch instead of cooking my dinner. :)

hynek commented 9 years ago

A man on a mission! :) I disagree with the setup.cfg -> tox.ini change tho because I run the tests without tox too. Actually tox is mostly for CI for me tbh.

ashald commented 9 years ago

AFAIR, py.test and tox are either written by the same guy or something like that - in any case, py.test config fall chain is pytest.ini -> tox.ini -> setup.cfg so as long as tox.ini in the dir it will work. I wish coverage would pay attention to it too. :)

OTOH setup.cfg is being distributed with the sdist (if you ever planing making an sdist provided that the package is pure python) and I don't see any reasons to keep things unrelated to packaging/distribution out there.

Though if you don't like the idea - feel free to decline PR, I won't have any hard feelings. :)

hynek commented 9 years ago

I could live with pytest.ini but tox.ini is IMHO confusing. As you say, the only link between tox and pytest is Holger. :)