hyochan / hackatalk

Open source chat app built-in expo managed workflow with graphql backend built-in Prisma and nexus.
https://website.hackatalk.dev
GNU General Public License v3.0
206 stars 148 forks source link

replace bcrypt-nodejs with bcrypt #190

Closed neverlish closed 4 years ago

neverlish commented 4 years ago

Specify project

Is your feature request related to a problem? Please describe.

Describe the solution you'd like write codes in below sequence, so make sure changes does not affect products.

  1. write test codes for function encryptCredential and validateCredential in server/src/utils/auth.ts
  2. replace bcrypt-nodejs with ~bcryptjs~ bcrypt

Describe alternatives you've considered use alternative npm

hyochan commented 4 years ago

Sounds awesome! However, I think we need to change to bcrypt instead of bcrypt-js since this doesn't seem to be maintained (last published 4years ago).

neverlish commented 4 years ago

Sounds awesome! However, I think we need to change to bcrypt instead of bcrypt-js since this doesn't seem to be maintained (last published 4years ago).

I agree :) I changed title and content of issue