search

hyochan / react-native-masonry-list

The Masonry List implementation which has similar implementation as the `FlatList` in React Native
MIT License
393 stars 55 forks source link

use refreshing from props if specified #13

Closed ahmethalac closed 2 years ago

ahmethalac commented 2 years ago

Description

In current version, even if refreshing prop is specified, MasonryList component does not care about the value of this prop. Reason is that (refreshing && isRefreshing) evaluates to false if isRefreshing is false and it is set to false just after onRefresh callback.

So, using || instead of && solves this problem because it prioritizes the value of refreshing from props, if there is no prop, it can continue to use value from state.

codecov[bot] commented 2 years ago

Codecov Report

Merging #13 (8e91812) into master (afe7cb9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           34        34           
  Branches        12        12           
=========================================
  Hits            34        34
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afe7cb9...8e91812. Read the comment docs.