Closed samzmann closed 2 years ago
Merging #17 (795c980) into master (3f26841) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 34 35 +1
Branches 12 13 +1
=========================================
+ Hits 34 35 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 100.00% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
index.tsx | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3f26841...795c980. Read the comment docs.
Happy to help :) Thanks for merging!
For some reason, my content container does cover all my items. Why?
@jduhking I'm not working on this anymore. Feel free to experiment and submit a new PR. Happy hacking :)
Description
This PR adds support for
horizontal
list layout, which is a common use of FlatList and ScrollView. This is achieved by modifying theflexDirection
of the column and row views:if
horizontal
is falsy (default behavior):flexDirection: "row"
, allowing to place columns from left to rightflexDirection: "column"
, allowing list items to be stacked from top to bottomif
horizontal
is true:flexDirection: "column"
, allowing to stack rows from top to bottom.flexDirection: "row"
, allowing to place list items from left to rightRelated Issues
There are no related issues. I was going to create one but then thought coding the feature myself was probably not so complicated so I decided to submit this PR instead :)
Tests
I did not add any tests. The current tests are passing. I only had to update snapshots. I tested manually on both iOS and Android devices, by using the following dummy data. Works as expected.
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.yarn lint && yarn tsc
yarn test
oryarn test -u
if you need to update snapshot.