search

hyochan / react-native-masonry-list

The Masonry List implementation which has similar implementation as the `FlatList` in React Native
MIT License
393 stars 55 forks source link

fix: React: ref is not a prop #21

Closed hanpanpan200 closed 2 years ago

hanpanpan200 commented 2 years ago

Description

Wants to control the MasonryList to scroll to top, so need to use ref. When use ref:

  1. Got error:

    React: ref is not a prop

  2. ref.current is undefined

Related Issues

https://github.com/facebook/react/pull/5744 https://stackoverflow.com/questions/38089895/react-ref-is-not-a-prop

codecov[bot] commented 2 years ago

Codecov Report

Merging #21 (43df0fe) into master (e74adb4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           31        31           
  Branches        11        11           
=========================================
  Hits            31        31
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e74adb4...43df0fe. Read the comment docs.

hanpanpan200 commented 2 years ago

Hi @hyochan can you merge the PR?

hyochan commented 2 years ago

Will release this to 1.1.1