hyochan / react-native-masonry-list

The Masonry List implementation which has similar implementation as the `FlatList` in React Native
MIT License
393 stars 55 forks source link

Fix `keyExtractor` placed on parent view #33

Closed hyochan closed 2 years ago

hyochan commented 2 years ago

Description

In 1.2.0 and 1.2.1, the keyExtractor was placed in the wrong view. Place this to correct child view.

Sorry for inconvenience 🙏

Related Issues

10

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

codecov[bot] commented 2 years ago

Codecov Report

Merging #33 (4fe59f4) into main (7229a50) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           36        36           
  Branches        13        13           
=========================================
  Hits            36        36           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7229a50...4fe59f4. Read the comment docs.