hyochan / react-native-masonry-list

The Masonry List implementation which has similar implementation as the `FlatList` in React Native
MIT License
393 stars 55 forks source link

Add optional refreshControl #39

Closed Conradmaker closed 1 year ago

Conradmaker commented 2 years ago

Description

refreshControl was always set to true. Make this changeable.

Related Issues

N/A

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

codecov[bot] commented 1 year ago

Codecov Report

Merging #39 (c1c5efc) into main (89250db) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head c1c5efc differs from pull request most recent head e26c244. Consider uploading reports for the commit e26c244 to get more accurate results

@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           36        41    +5     
  Branches        13        18    +5     
=========================================
+ Hits            36        41    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

FengFuLiu commented 1 year ago

I have the same problem ,When PR can be merged?

hyochan commented 1 year ago

Sorry! I've just managed to update this PR myself since there isn't traction.

I'll release to the newer version soon!

FengFuLiu commented 1 year ago

Sorry! I've just managed to update this PR myself since there isn't traction.

I'll release to the newer version soon!

Thanks!