hyochan / react-native-masonry-list

The Masonry List implementation which has similar implementation as the `FlatList` in React Native
MIT License
393 stars 55 forks source link

data could be readonly #42

Closed pvinis closed 1 year ago

pvinis commented 1 year ago

Description

We have some relay types that are marked as readonly, and MasonryList is complaining that data is readonly when it expects mutable. data is not really doing any changes, so we might as well mark it readonly. cc @patrinoua

Related Issues

Replace this paragraph with a list of issues related to this PR from our [issue database]. Indicate, which of these issues are resolved or fixed by this PR.

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

codecov[bot] commented 1 year ago

Codecov Report

Merging #42 (aa71f81) into main (89250db) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           36        36           
  Branches        13        13           
=========================================
  Hits            36        36           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hyochan commented 1 year ago

Closes due to inactivity