hyochan / react-native-masonry-list

The Masonry List implementation which has similar implementation as the `FlatList` in React Native
MIT License
399 stars 55 forks source link

Inclusion of `expo` as a peer dependency is causing warnings #60

Open doelgonzo opened 1 year ago

doelgonzo commented 1 year ago

Describe the bug "expo" is listed as a dependency in the core project but only used in the Example project. Is there a reason for this? It is causing warnings to be thrown in non-expo projects due to a missing peer dependency. Maybe it needs to move to devDependencies?

To Reproduce In a non-expo project, add "@react-native-seoul/masonry-list": "1.4.2", to package.json and run yarn install, see warning:

YN0002: │ @test/mobile@workspace:packages/mobile doesn't provide expo (pb91be), requested by @react-native-seoul/masonry-list

Expected behavior No warnings should print to console unless expo is being used in the core project itself. Maybe we need

Screenshots N/A

Desktop (please complete the following information):

N/A

Smartphone (please complete the following information):

N/A

Additional context using Yarn 3 and it shows warnings to help manage peer deps