hyochan / react-native-masonry-list

The Masonry List implementation which has similar implementation as the `FlatList` in React Native
MIT License
393 stars 55 forks source link

VirtualizedList: You have a large list that is slow to update - make sure your renderItem function renders components that follow React performance best practices like PureComponent, shouldComponentUpdate, etc. Object { #9

Closed soly2014 closed 3 years ago

soly2014 commented 3 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

hyochan commented 3 years ago

@soly2014 This is interesting. I've just gone through react-native-virtualized-masonry and this just wraps the whole thing inside the FlatList instead of ScrollView.

Do you think this would solve the problem?

hyochan commented 3 years ago

I think this is rather related to https://stackoverflow.com/questions/44743904/virtualizedlist-you-have-a-large-list-that-is-slow-to-update. Check if you are not re-rendering react-native-masonry-list.

Please come back if you still have a problem.

soly2014 commented 3 years ago

hey @hyochan thank u very much. yes i think using FlatList instead of ScrollView will solve the problem

hyochan commented 3 years ago

Actually I dont currently agree. Please refer to https://stackoverflow.com/questions/44743904/virtualizedlist-you-have-a-large-list-that-is-slow-to-update

And see if you can solve the problem.