hyochan / talktalk-node

(Deprecated via hackatalk-server) Graphql node project using prisma for talktalk.

Other

17 stars 7 forks source link

Migrated datamodel. #25

Closed hyochan closed 5 years ago

hyochan commented 5 years ago

Datamodel should suite with talktalk-rn.

codecov[bot] commented 5 years ago

Codecov Report

Merging #25 into master will decrease coverage by 3.71%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #25      +/-   ##
=========================================
- Coverage   42.42%   38.7%   -3.72%     
=========================================
  Files           6       5       -1     
  Lines          33      31       -2     
  Branches        2       2              
=========================================
- Hits           14      12       -2     
  Misses         19      19

hyochan commented 5 years ago

I feel like this modelling should be done together. This is very important to be discussed further.

hyochan commented 5 years ago

How about this one.

cometkim commented 5 years ago

I still think we need an additional model for Room and User relationship because there are many many modeling concerns like membership, preferences, roles, etc...

hyochan commented 5 years ago

Would you then create another PR taking this? I'll close this one then.