hyojin / material-ui-datatables

An another React Data tables component.

MIT License

165 stars 58 forks source link

Upgraded packages, and fixed deprecation warnings #23

Closed Crecket closed 7 years ago

Crecket commented 7 years ago

I seem to have fixed most of the warnings from outdated/deprecated packages. I updated things like react and material-ui to the latest version which seems to work fine.

coveralls commented 7 years ago

Coverage increased (+0.3%) to 86.735% when pulling 3df5492440afdcd1defa6e9f7ece3c038885e771 on Crecket:master into ebc2291840ac16c4ea1c1d545d3be78724281334 on hyojin:master.

hyojin commented 7 years ago

@Crecket Hi, thanks for your PR I've tested it and I found 2 things we need to check before upgrading the material-ui module. first one is that check boxes are not working properly with material-ui 0.18.0 and second one is that it print a warning in runtime.

Warning: Unknown prop `onCellDoubleClick` on <tbody> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop

I'll merge it after I find reasons and fix that. :)

hyojin commented 7 years ago

21

Crecket commented 7 years ago

Could you publish these changes to npm? Thanks for fixing that other issue btw @hyojin

hyojin commented 7 years ago

@Crecket Sure, I'll publish within the week! :)

hyojin commented 7 years ago

@Crecket Pls try 0.18.0 :)