search

hyojin / material-ui-datatables

An another React Data tables component.
MIT License
165 stars 58 forks source link

removed setting ctrlKey since it's read-only #62

Closed joshuagish closed 7 years ago

joshuagish commented 7 years ago

event.ctrlKey is read-only which causes errors in the console when we try to set it

see https://www.w3schools.com/jsref/event_ctrlkey.asp

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 87.898% when pulling 6dc564b2221b40bf00a99bbb5c0beb5ed95e584d on thecitywelivein:master into 91c184a8920573fc02b61534de3ce848785e8464 on hyojin:master.

hyojin commented 7 years ago

@thecitywelivein Hi, thanks for your PR. Yes, it's read-only. but it's the way to handle multiple selection in material-ui internally now. Probably it will be disappeared on v1. By the way, I couldn't get errors on latest chrome and FF. which browsers throw that error?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 87.975% when pulling 5b38d9e15579db573011669f6083b9348ab093a4 on thecitywelivein:master into 91c184a8920573fc02b61534de3ce848785e8464 on hyojin:master.

joshuagish commented 7 years ago

Looks like typescript is causing the error to be shown. Wrapping it in a try/catch prevents errors for me. I've updated the PR

This is the error screen shot 2017-09-22 at 3 27 15 pm