ifc openings fix for instances and testing - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

349 stars 74 forks source link

ifc openings fix for instances and testing #1009

Closed anthonie-kramer closed 1 year ago

anthonie-kramer commented 1 year ago

BACKGROUND:

What led to this work, and what is the broader context of this change? Openings were not working properly for IFC export due to the LocalTransform not being included. Instances were also not being used to create openings.

DESCRIPTION:

What does this PR specifically accomplish? Transforms openings to the correct location Creates new openings for instance objects so they can be used to create the IFCRELVOIDSELEMENT

TESTING:

How should a reviewer observe the behavior desired by this pull request? There are two new tests which use hypar model.json files to ensure the IFC export is working as expected

FUTURE WORK:

Is there any future work needed or anticipated? Does this PR create any obvious technical debt? We should refactor elements so that Openings can be exported in a more straightforward way

REQUIRED:

[x] All changes are up to date in CHANGELOG.md.

COMMENTS:

Any other notes.

This change is