instance openings for ifc - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

349 stars 74 forks source link

instance openings for ifc #1010

Closed anthonie-kramer closed 11 months ago

anthonie-kramer commented 1 year ago

BACKGROUND:

What led to this work, and what is the broader context of this change?
Openings were not being created for ElementInstance objects
Openings were not being transformed for their LocalTransform

DESCRIPTION:

What does this PR specifically accomplish?
Adds correct transform and creates openings that can be used for the IFCRELVOIDSELEMENT creation

TESTING:

How should a reviewer observe the behavior desired by this pull request?
I have added a test that uses instances and creates the openings sucessfully

FUTURE WORK:

Is there any future work needed or anticipated? Does this PR create any obvious technical debt?
We should refactor Elements to find a better way to include Openings in a more straightforward way

REQUIRED:

[x] All changes are up to date in CHANGELOG.md.

COMMENTS:

Any other notes.

This change is