Closed srudenkoamc closed 1 year ago
Looks good!
I assume that the
Door.cs
definition will be unified with the one from theDoors
layout function.Also, do you mind producing an IFC file with a door that I can review?
Reviewed 4 of 7 files at r1, 4 of 4 files at r3, all commit messages. Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @srudenkoamc)
Elements/test/ContentTests.cs
line 94 at r3 (raw file):} // TODO: The test fails in 70 of 100 test runs. Uncomment when it is fixed.
Did you get this working?
The Door.cs
definition will be unified with the one from the Doors
layout function. After the merge I'm planning to make a separate PR to update 'Elements' in HyparSpace. During this I'll check if everything works and will remove the old Door definition.
About the test - I've just commented it for now because it sometimes does break the build and sometimes doesn't. Eric said that he worked with it and that he will take a look.
BACKGROUND:
DESCRIPTION:
TESTING:
FUTURE WORK:
This change is