Closed srudenkoamc closed 10 months ago
Reviewed 1 of 22 files at r10, 6 of 7 files at r11, 2 of 2 files at r12, 1 of 1 files at r13, all commit messages. Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @srudenkoamc)
Elements/src/Door.cs
line 86 at r13 (raw file):Representation = representation ?? new Representation(new List<SolidOperation>() { }); Opening = new Opening(Polygon.Rectangle(width, height), depthFront, depthBack, GetOpeningTransform()); Id = id != default ? id : Guid.NewGuid();
was this due to a serialization issue? I believe we can also create an empty constructor which may also fix the serialization issues with newtonsoft
This is a fix for a situation when a door has the default Guid instead of a generated one when a Guid isn't specified in the constructor parameters. The fix for the serialization issue is in the another PR (https://github.com/hypar-io/Elements/pull/1050).
... It looks like all the comments were addressed... If there are no more updates I will merge!
_Reviewable_ status: :shipit: complete! 1 of 1 approvals obtained (waiting on @srudenkoamc)
No updates from me. The changes may be merged.
BACKGROUND:
DESCRIPTION:
FUTURE WORK
TESTING:
This change is