Add edge intersection test to Contains3D - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

347 stars 74 forks source link

Add edge intersection test to Contains3D #1047

Open DmytroMuravskyi opened 10 months ago

DmytroMuravskyi commented 10 months ago

BACKGROUND:

This PR fixes issue https://github.com/hypar-io/Elements/issues/767

DESCRIPTION:

Covers function already had needed logic implemented. Since the only difference between them is how they treat containment, this logic is reused for Contains3D.
Implementation of Cover is moved into shared static Contains function.

TESTING:

Added Contains3d test to PolygonTests.

FUTURE WORK:

There are inconsistency between different Covers and Contains functions described in the issue. New issue will be created to address this.

REQUIRED:

[x] All changes are up to date in CHANGELOG.md.

This change is