call update representations on child elements as well - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

347 stars 74 forks source link

call update representations on child elements as well #1052

Closed wynged closed 10 months ago

wynged commented 10 months ago

BACKGROUND:

Content elements didn't show up with latest elements release, problem starting at this PR #1017 where we stopped calling UpdateRepresentations a second time. This meant content elements didn't have representations, which means they don't have an object in the threeJS scene, which means we can't replace them with the glb mesh.

DESCRIPTION:

Call update representation on all sub elements that are automatically added that are geometric elements.

TESTING:

use this alpha with a function that makes content.

FUTURE WORK:

Some content was mysteriously appearing still in the SpaceTypes function, knowing why this happened might reveal other inconsistencies in when representations exist or don't

REQUIRED:

[ ] All changes are up to date in CHANGELOG.md.

COMMENTS:

Any other notes.

This change is