`AdaptiveGrid.AddEdge` no longer delete edges in case where new edge partially overlaps old edges without intersections. - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

347 stars 74 forks source link

`AdaptiveGrid.AddEdge` no longer delete edges in case where new edge partially overlaps old edges without intersections. #1070

Closed DmytroMuravskyi closed 9 months ago

DmytroMuravskyi commented 9 months ago

BACKGROUND:

When creating grid from a set of circulation objects I found that some edges disappear.
After investigation I found a bug in partial overlap of two edges: when one end is outside and one is inside.

DESCRIPTION:

Register missing intersection points in AddCutEdge.
It's not an issue if some of them will appear in the list several times since the list is later ordered and checked for duplicates.

TESTING:

Added AdaptiveGridAddCutWithOverlap to cover problematic case.

REQUIRED:

[x] All changes are up to date in CHANGELOG.md.

This change is