handle folders which look like elemetns but aren't - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

347 stars 74 forks source link

handle folders which look like elemetns but aren't #1073

Closed wynged closed 8 months ago

wynged commented 8 months ago

BACKGROUND:

De-serializing folders in tests broke recently because we started falling back to elements if something has an "Id" property, which folders do, but they are not Elements

DESCRIPTION:

Check if there is a discriminator before falling back to Element or GeometricElement. non-elements can't fallback to these types even if they have an Id or Representation property.

TESTING:

try to make/run a function that as a folder as an input. You will get a de serialization error on de serializing the input, then try with this change.

FUTURE WORK:

NA

REQUIRED:

[ ] All changes are up to date in CHANGELOG.md.

COMMENTS:

Any other notes.

This change is