fix centroids in polygons with collinear vertices - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

349 stars 74 forks source link

fix centroids in polygons with collinear vertices #947

Closed wynged closed 1 year ago

wynged commented 1 year ago

BACKGROUND:

Centroids were returning strange results because vertices that were collinear with other perimeter vertices could move the centroid. This isn't really sensible because a centroid represents a sort of center of mass of the 2D shape, and shouldn't be affected by extra perimeter vertices.

DESCRIPTION:

Remove collinear vertices before computing the centroid.

TESTING:

Test passes.

FUTURE WORK:

Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

[x] All changes are up to date in CHANGELOG.md.

COMMENTS:

Any other notes.

This change is

ikeough commented 1 year ago

What's the status here? Should we push to get this in?