Missing spaces: Leaf branches are not considered now during cycles search in Network.FindAllClosedRegions - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

349 stars 74 forks source link

Missing spaces: Leaf branches are not considered now during cycles search in Network.FindAllClosedRegions #991

Closed srudenkoamc closed 1 year ago

srudenkoamc commented 1 year ago

BACKGROUND:

Network.FindAllClosedRegions cannot find all cycles correctly in some cases.

DESCRIPTION:

Moved the logic that searches from Network.FindAllClosedRegions for cycles into a separate class NetworkCycleCoverage.
Added NetworkNode class that contains index and position of vertex. It allows to simplify the code significantly.
Leaf branches were removed from the cycles search in Network.FindAllClosedRegions.

FUTURE WORK:

Current changes allow to simplify code significantly. Network.FindAllClosedRegions output type can be changed to List< List< Vector3 > >. In this case it is possible to return networkCycleCoverage.CyclesPoints instead of networkCycleCoverage.CyclesIndices in order to get rid of some of the function results postprocessing.

This change is

srudenkoamc commented 1 year ago

Reviewable status: 0 of 1 approvals obtained (waiting on @srudenkoamc)

_Elements/src/Search/NetworkCycleCoverage.cs line 397 at r1 (raw file):_
    }

    internal class NetworkNode
One class per file please.

Fixed: Moved NetworkEdge and NetworkNode classes to separate files