hypar-io / Elements

The smallest useful BIM.
https://www.hypar.io
MIT License
349 stars 74 forks source link

Closed regions search refactoring #992

Closed srudenkoamc closed 1 year ago

srudenkoamc commented 1 year ago

BACKGROUND:

DESCRIPTION:

TESTING:

FUTURE WORK:


This change is Reviewable

srudenkoamc commented 1 year ago

One little comment.

Reviewed 5 of 5 files at r1, all commit messages. _Reviewable_ status: 1 change requests, 0 of 1 approvals obtained (waiting on @srudenkoamc)

_Elements/src/Search/NetworkCycleCoverage.cs line 192 at r1 (raw file):_

                var edge = GetEdge(path[j], path[j + 1]);

                // if (edge == null)

Let's remove this commented code. Even though it was there previously, I don't think it should be.

@wynged , fixed in https://github.com/hypar-io/Elements/pull/992/commits/399ec29cbb7bded43592a0e552f7bc6c9818f9eb.