Missing spaces: Implemented traverse algorithm that is based on edges rather than nodes - Githubissues

hypar-io / Elements

The smallest useful BIM.

https://www.hypar.io

MIT License

349 stars 74 forks source link

Missing spaces: Implemented traverse algorithm that is based on edges rather than nodes #995

Closed srudenkoamc closed 1 year ago

srudenkoamc commented 1 year ago

BACKGROUND:

Network.FindAllClosedRegions cannot find all cycles correctly in some cases (workflow https://hypar.io/workflows/30abf136-8dfe-40c0-9b03-2cd6b4bbaf40).

DESCRIPTION:

Added two tests to cover one of the fixed issues and basic functionality.
Implemented new traverse algorithm for the closed regions search that is based on the edges rather than nodes.
New traversing algorithm also works correctly with several leaves inside a single closed region.
Sometimes walls center lines intersections are not handled correctly. Added postprocessing for such cases.

TESTING:

Significant improvement in workflow https://hypar.io/workflows/30abf136-8dfe-40c0-9b03-2cd6b4bbaf40.
All tests passed.

FUTURE WORK:

Walls center lines intersections issues still exist. A proper fix instead of postprocessing (or along with it) is required.

This change is