search

hypeJunction / hypeWall

Wall functionality for Elgg
www.hypejunction.com
2 stars 3 forks source link

May it fix #80 [WIDGET ENTRIES]? DISCLAIMER: Elgg newbie ;) thanks hypeJunction #81

Open feroda opened 8 years ago

feroda commented 8 years ago

[Worksforme on Elgg 1.9, never tried in Elgg 2.x]

[commit comment follows] Setting the default entries limit, avoid and memory leaks and page loading timeouts when the wall has many entries.

To reproduce the bug: add the Wall widget, do not update its settings, and create 10 wall posts, you will see 10 posts in the widget. If you create 100, you will se 100.

To see it is fixed: do the same and when you add the widget if there are more than 4 posts, you will ever see 4 posts

hypeJunction commented 8 years ago

Those lines are already there in views/default/widgets/wall/edit.php. Edit view is rendered before content. The only time you might experience the problem you are describing is when the widget is first viewed by someone who doesn't have permissions to edit, which is an odd situation.

hypeJunction commented 8 years ago

I have a changelog generator which uses angular rules, if you rename the commit to: fix(widgets): set default limit in widget content or something similar and move Fixes #80 into the end of the description, I can merge it.

feroda commented 8 years ago

I think that if you are sure that edit.php is included before content.php, you should not apply my PR. Maybe this does not happen in Elgg 1.9 ? Because in our Elgg 1.9 site we have the issue #80 and the code in this PR fixes the bug.

hypeJunction commented 8 years ago

I think I have fixed it at some point in the past, so it's possible that you are using an older version.