search

hypeJunction / hypeWall

Wall functionality for Elgg
www.hypejunction.com
2 stars 3 forks source link

Private access fails for posts #83

Closed jalemany1 closed 7 years ago

jalemany1 commented 8 years ago

I am using the hypeWall plugin (4.4.8 version) in my Elgg installation (2.2.1 version). The plugin works fine but (with the wall_friends_tag property enabled) if I want publish a private post in my Wall with an empty tag (no tagged), the 'access_id' value changes from ACCESS_PRIVATE to ACCESS_LOGGED_IN.

hypeJunction commented 7 years ago

The access never changes to logged in. If you have tagged friends, there will be a new access collection created.

jalemany1 commented 7 years ago

Please try to create a private publication with hypeWall without labeling any user. The publication is kept public.

jalemany1 commented 7 years ago

The error is in line SavePost#178, this function does not create a collection of friends but always returns the value 1.

If we look at the class that should create the collection of friends AccessCollection, we can see that the only thing that happens is that AccessCollection object is created but the collection is never saved in the database. 'createCollection' function is never called.

hypeJunction commented 7 years ago

Should be fixed now.