search

hypeapps / NoiseView

Android library written in kotlin that add a noise effect to image.
Other
45 stars 7 forks source link

Screen goes black after few seconds #5

Open rostopira opened 7 years ago

rostopira commented 7 years ago

I've tried both Google Play version and compiled from sources. It works for few seconds, then screen goes black and process dies. No errors or crashes in logcat. Idunno wtf is that, but you probably need to know about it ¯_(ツ)_/¯ Device: Galaxy Note 4 with stock Marshmallow UPD: Same thing on Xperia Z1 with stock Lollipop

rostopira commented 7 years ago

I've fully rewrote regular noise and left scratches untouched. It works now and looks better IMHO, but needs few tweaks before it could be shown to people without shame :D

hypeapps commented 7 years ago

Thank you! Will you make pull request after you're done?

rostopira commented 7 years ago

@hypeapps yep, but I need few hours to finish But here really a lot of changes. Noise are created with RenderScript now. Also, I've refactored NoiseRenderable a bit.

rostopira commented 7 years ago

OK, so it's early for PR, because of few things. Scratches became invisible, because intensity slider in my code controls dots frequency, and in your code it controls transparency. Also, I've considered that scale 1f renders frame in original resolution, and 0.5f renders quarter of it and scales up. Scale down - noise dots bigger. I've done everything wrong :D Checkout fork to see, what I'm talking about: https://github.com/rostopira/NoiseView My suggestion is to make separate options for regular noise and scratches

hypeapps commented 7 years ago

I really like your changes. What do you mean by make seperate options? Will you edit all fields of view? Can you explain more?