search

hypeapps / episodie

Episodie is a TV show time tracker app with unusual design written in kotlin and clean architecture approach. Get to know how much time you spent watching tv shows.
GNU General Public License v3.0
127 stars 20 forks source link

Unused repositories? #23

Closed Rudloff closed 6 years ago

Rudloff commented 6 years ago

Hello,

I am packaging you app for F-Droid. We had to patch it to remove some untrusted Maven repositories: https://gitlab.com/fdroid/fdroiddata/blob/cdeed9c43adabcd48674e31d5d5f20ae297ef49d/metadata/pl.hypeapp.episodie/repositories.patch The app seems to build correctly without them.

What are they used for? If they are not used, would it be possible to remove them?

Bubu commented 6 years ago

maven { url 'https://dl.google.com/dl/android/maven2/' } should just be a synonym for google() right?

The arturbosch one seems to be needed for detekt whatever that is :). But we can easily remove that with sed instead of a patch (patches tend to break way more easily).

Really not sure about the idescout one.

hypeapps commented 6 years ago

@Rudloff @Bubu Don't worry, just delete them. Artur Bosch(Detekt) - is kotlin static code analysis tool for Kotlin. IDEScout(SQLScout) - is IDE tool to manage database. I tested it and I forgot to delete the dependency.