Read response Message from server on send

hypebeast / go-osc

Open Sound Control (OSC) library for Golang. Implemented in pure Go.

MIT License

202 stars 46 forks source link

Read response Message from server on send #21

Closed loffa closed 4 years ago

loffa commented 8 years ago

According to the remote protocol specification for the sound mixer Behringer X32 here the server creates a response when sending a message.

I tried to read the response and have it as a return parameter of the send function.

daveyarwood commented 4 years ago

I think this PR can be closed because:

It's over 3 years old and thus out of date with the current state of master.
It makes a breaking change to the signature of client.Send.
I think having the client.Send function also receive after sending is not the correct behavior. The behavior @loffa described sounds specific to a particular use case and might be better served in a more general way. Perhaps there could be a separate SendAndReceive method?

loffa commented 4 years ago

Hey, great idea.

I will create a new PR with a separated function for SendAndReceive instead. Have actually been waiting for some action in this Lib to get my integration with the mixer working.