search

hyper63 / alternative-stack

A Remix Stack using hyper cloud as a services tier
https://hyper.io
17 stars 0 forks source link

chore: remove lockfile #4

Closed MichaelDeBoey closed 2 years ago

MichaelDeBoey commented 2 years ago

For more info, see https://github.com/remix-run/remix/pull/3110.

You should probably also implement something similar in remix.init for only ignoring these files in the repo but not when the project is created like we did in https://github.com/remix-run/indie-stack/pull/79, https://github.com/remix-run/blues-stack/pull/67 & https://github.com/remix-run/grunge-stack/pull/53.

TillaTheHun0 commented 2 years ago

Thanks @MichaelDeBoey! Makes sense to me, and i'll fix the CI in the PR that implements the changes you suggested 👍

TillaTheHun0 commented 2 years ago

@MichaelDeBoey see #6 for how I implemented this.

The stack itself is sort of a library, so having useLockFile set to false for this repo's CI makes sense. But once the stack is initialized, it's no longer a library, and more of an application, and so ought to have a lockfile and enforce it in CI.

So I added some ✨ in remix.init to set to useLockFile to true on stack init.