Definision of setChangeFPS() is wrong/confusing

[arnuschky]

The definition of setChangeFPS() in SpriteImage.js is wrong or at least confusing:

        /**
         * Set the elapsed time needed to change the image index.
         * @param fps an integer indicating the time in milliseconds to change.
         * @return this
         */
        setChangeFPS:function (fps) {
            this.changeFPS = fps;
            return this;
        }

Here, the integer indicates the time between frames. That is, high integer, fewer frames-per-second (FPS). Low integer, higher FPS.

That is, the parameter does exactly the opposite of one would expect.

[hyperandroid]

Maybe. Do you have a suggestion for a new method ?

Thanks.

• ibon

[arnuschky]

Well, either you change the behavior of the method such that it actually sets the frames per second, or you rename it for something like setAnimationSpeed(timeDelta).

[hyperandroid]

Didn't i told previously i love pull requests ? Feel free to submit your own. And don't remove the original method :)

thanks.

• ibon