search

hyperaudio / hyperaudio-lite

Hyperaudio Lite - a Super-lightweight Interactive Transcript Player
MIT License
128 stars 38 forks source link

Change missing `data-player-type` alert to a console warning #164

Closed maboa closed 1 year ago

maboa commented 1 year ago

Hyperaudio Lite will still work without data-player-type so it's better fro backwards compatibility if we just produce a console warning.

maboa commented 1 year ago

After looking at this I think the initial decision is correct, as the number of players we support increases, users will have to specify the type of player we're using, because we cannot always reliably detect it. An alert is a much more obvious indication of what has happened and how to remedy.