remove plugins_url() for twitter since already a URL and use proper deps arg for wp_enqueue_script

hyperaudio / wordpress-hyperaudio

a wordpress plugin to display interactive transcripts

GNU General Public License v2.0

12 stars 10 forks source link

remove plugins_url() for twitter since already a URL and use proper deps arg for wp_enqueue_script #123

Closed composerjk closed 12 months ago

composerjk commented 1 year ago

Don't know if you want a specific version of the twitter widgets.js. So, the version could possibly be blank or set to something other than 1.0.0.

maboa commented 12 months ago

Yes. This looks fine.

maboa commented 12 months ago

@composerjk In the end I removed the inclusion of the external widget js as it was being concatenated to the base URL, so not loading and besides it doesn't appear to be required for sharing. See https://github.com/hyperaudio/wordpress-hyperaudio/issues/131