twitter widgets.js doesn't load due to use of plugins_url() when should be string

hyperaudio / wordpress-hyperaudio

a wordpress plugin to display interactive transcripts

GNU General Public License v2.0

11 stars 8 forks source link

twitter widgets.js doesn't load due to use of plugins_url() when should be string #127

Closed composerjk closed 10 months ago

composerjk commented 11 months ago

Already submitted fix in #123. Noting here since I see you're getting ready to submit (or maybe already have) to the WP plugins directory. Great.

See this line: https://github.com/hyperaudio/wordpress-hyperaudio/blob/a812c5411251de4a4ece6ce81330c71fb933725c/wp-hyperaudio/hyperaudio.php#L235

maboa commented 10 months ago

Merged. Many thanks! https://github.com/hyperaudio/wordpress-hyperaudio/pull/123

maboa commented 10 months ago

Ah. @composerjk Just noticed this doesn't actually work on external JS for me. It concatenates the URL to the base URL and produces a warning in the console:

Loading failed for the <script> with source “http://example.com/wordpress/wp-content/plugins/wp-hyperaudio/https://platform.twitter.com/widgets.js?ver=1.0.0”.

I'm going to remove it for now as I'm not sure why it's needed.