search

hyperboria / android

Android app for mesh networking with cjdns
GNU General Public License v3.0
159 stars 40 forks source link

Drawer options #10

Closed benhylau closed 9 years ago

benhylau commented 9 years ago

cjdns-ui-2

benhylau commented 9 years ago

Also renamed MeshnetService to CjdnsService. That's okay right?

benhylau commented 9 years ago

Dagger is for later. Components like the Logger will be provided through the CjdnsApplication.DefaultModule, but more importantly we will provide peering credentials via mocked up Modules during development.

ghost commented 9 years ago

Looks good, I'm fine with whatever rename you propose. The idea behind MeshnetService vs. CjdnsService was to only call the bits directly related running cjdroute this way, to avoid confusion moving forward. The service will probably eventually not only take care of executing CjdrouteTask, but also managing wifi etc.

Here's how you kill cjdroute, btw :) https://github.com/BerlinMeshnet/cjdns-android/blob/master/src/main/java/berlin/meshnet/cjdns/MeshnetService.java#L71-L75

I don't remember why I added that to the service instead of the task.

benhylau commented 9 years ago

The reason I renamed was because I intend to merge the Task into CjdnsService, and make CjdnsService an IntentService. This allows third-party apps to start cjdns via an Intent, and the Process will start in the background. Management of WIFI, fetching from peerStats, will be via a different component.

See second last comment here.

dpsm commented 9 years ago

LGTM