hyperboria / android

Android app for mesh networking with cjdns
GNU General Public License v3.0
159 stars 40 forks source link

Make it work on rooted pre-Lollipop devices #49

Closed benhylau closed 8 years ago

benhylau commented 8 years ago
benhylau commented 8 years ago

Some more notes:

  1. Switched everything to Rx to better manage the threads, unsubscribe when the views are gone, etc.
  2. The default route we discussed gets removed automatically by the system once cjdroute shuts down. Not too intrusive.
  3. Cleaned up the README and made tasks in issue tracker for the old TODOs that aren't already in there. https://github.com/benhylau/cjdns-android/blob/run-as-su/README.md
  4. Persist PID over Java process restart that @lgierth and I talked about. This works fine most of the time. It isn't perfect, because if the kill somehow failed, we still remove the PID from data store. We can improve this later by checking for any cjdroute process.

@sssemil @lgierth @kpcyrd @prurigro Will merge after I get a few approvals.

sssemil commented 8 years ago

Sounds ok, but can't test it, so I'm neutral about this one.

benhylau commented 8 years ago

Works on my Nexus S running 4.4.4. Seems to have problems on a Gingerbread device, but merging for now.