search

hyperboria / android

Android app for mesh networking with cjdns
GNU General Public License v3.0
159 stars 40 forks source link

Manifest should specify a minimum API level #5

Closed kpcyrd closed 9 years ago

kpcyrd commented 10 years ago

In file AndroidManifest.xml

Manifest should specify a minimum API level with <uses-sdk android:minSdkVersion="?" />; if it really supports all versions of Android set it to 1.
kpcyrd commented 10 years ago

In MainActivity we have textIsSelectable, which is only available in API level 11 and fontFamily, which is only available in API level 16.

ghost commented 10 years ago

I added minSdkVersion=11 for ActionBar: https://github.com/berlinmeshnet/cjdns-android/compare/actionbar

textIsSelectable and fontFamily can actually be removed -- my initial idea was to have MainActivity continuously display cjdroute's output, but for now I'd rather show simple peer stats.

In the end we'll have to use at least version 14 / Android 4.0, because that's when VpnService was introduced. cjdroute itself is compatible down to version 7 / Android 2.1, so that's the ideal minSdkVersion we should shoot for in the long term.

benhylau commented 9 years ago

The new Toolbar-based ActionBar implementation supports all the way down to API 7. I think there are some other things used that requires API 11, but I think API 11 is a reasonable baseline requirement.

By the way, the min and target SDK levels are now specified in the build.gradle, which overrides what's in the AndroidManifest.xml.

benhylau commented 9 years ago

Should we close this issue?

ghost commented 9 years ago

Go ahead and do it, I invited you to the org

benhylau commented 9 years ago

Cool, thanks for the invite :smile: