search

hyperboria / bugs

Peer-to-peer IPv6 networking, secure and near-zero-conf.
154 stars 17 forks source link

contrib/Python fixes #128

Closed MaStr closed 7 years ago

MaStr commented 8 years ago

Problem was that some parameters were not parsed correctly.

Original PR: #121 Fixed #120

commit 4e90beb6ccfb702a191cc304ec0ac067d7faf3a9 Author: Cy Date: Sat Apr 16 20:25:40 2016 -0700

Fixed broken bad cjdnsadmin.py

What the heck were they even doing with oargList...

commit b2e1afa2279a11b859dde76f430ff769f80f79d8 Author: Cy Date: Sat Apr 16 11:23:40 2016 -0700

forgot an exception
MaStr commented 8 years ago

I was also affected by that bug, and decided to fix PR #121 with the whitespace / tab issue. Now, we can see the changes properly.

ansuz commented 8 years ago

As far as I can tell this looks correct, but I'd have to play with it (and the previous version) to confirm.

Does the argument parsing change the usage at all? I'd be most worried about breaking any scripts that others had built on top of the existing library.

MaStr commented 8 years ago

To be honest, I only took care about the tab vs whitespace conflict. I reviewed the changes agains dynamic-endpoints.py , which did not look like a change.

As far as I understood, it is mostly changed to follow a correct ordering of a function call.

For myself, I don't have time constrains, so play around with it :) - I copied my adjustments over to the relevant nodes.

MaStr commented 7 years ago

Hi, what's up with that PR? Should I issue it against cjdelisle/cjdns

edit: ok, just saw the entrance comment. Better to do so. Don't you think it might be useful to just remove & delete the PRs from this repository?

best regards Matthias

ansuz commented 7 years ago

Yea, a PR to cjdelisle/cjdns would be best. This is just an issue tracker now. Thanks.

MaStr commented 7 years ago

was merged with 05a29812e7f659d9e6495f65314dac463f1d98f3 on upstream branch crashey