search

hyperboria / bugs

Peer-to-peer IPv6 networking, secure and near-zero-conf.
153 stars 17 forks source link

WIP: Contrib reactphp #134

Closed wfleurant closed 8 years ago

wfleurant commented 8 years ago

The table will automatically refresh once a second. It has a blocking call to sqlite-db, but is useful for those wanting to save peerstats / datausage for a graph or summary report. Below is an early screenshot of the index view (before twbs/css):

peerstats_index

ansuz commented 8 years ago

This has been sitting here for a week. Any objections to merging?

ansuz commented 8 years ago

ping @lgierth @kpcyrd

ghost commented 8 years ago

let's do it

kpcyrd commented 8 years ago

I think it's really interesting to have a practical example for the cjdns admin api, due to it's size we could consider moving this in it's own repository :)

wfleurant commented 8 years ago

thanks again kp, so the only input i found is originating from the cjdns admin.

the other user input for hits a sqlite library which is definitely escaped. the last is any phluid server.php request->get('user-input') responsibility. it should* render text for templates and for console. i'll verify this and also serve it up for fuzz testing.

if it goes in a separate repo, it'll rot. May be if we get another head on it.. /me nudges @dansup

wfleurant commented 8 years ago

fuzzing causin a ruckus.. 

PHP Fatal error:  Uncaught exception 'InvalidArgumentException' 
with message 'Invalid request string' in 
/.../cjdns/contrib/reactphp/vendor/guzzlehttp/psr7/src/functions.php:445

still crashes with latest guzzlehttp/psr7 (dev-master 5882861)

wfleurant commented 8 years ago

and yea.. other breakage.. 

PHP Fatal error:  Uncaught exception 'InvalidArgumentException' 
with message 'Invalid request string' in 
/.../cjdns/contrib/reactphp/vendor/guzzlehttp/psr7/src/functions.php:469

not even looking further..