search

hyperboria / bugs

Peer-to-peer IPv6 networking, secure and near-zero-conf.
153 stars 17 forks source link

warning: variable does not need to be mutable #207

Open marek22k opened 1 year ago

marek22k commented 1 year ago

A warning is issued during compilation:

$ ./do
    Updating crates.io index
    Updating git repository `https://github.com/cjdelisle/boringtun`
    Updating git repository `https://github.com/CJDNS-Development-Team/CJDNS`
    Updating git repository `https://github.com/cjdelisle/sodiumoxide`
    Updating git submodule `https://github.com/jedisct1/libsodium.git`
  Downloaded untrusted v0.7.1
  Downloaded vec_map v0.8.2
  Downloaded walkdir v2.3.1
  Downloaded dirs-sys-next v0.1.2
  Downloaded daemonize v0.4.1
  Downloaded dirs-next v2.0.0
  Downloaded ipnetwork v0.18.0
  Downloaded pnet_base v0.29.0
  Downloaded adler v0.2.3
  Downloaded itoa v0.4.7
  Downloaded cfg-if v0.1.10
  Downloaded pnet_sys v0.29.0
  Downloaded textwrap v0.11.0
  Downloaded autocfg v1.0.1
  Downloaded atty v0.2.14
  Downloaded tokio-macros v1.7.0
  Downloaded pkg-config v0.3.19
  Downloaded boxfnonce v0.1.1
  Downloaded instant v0.1.9
  Downloaded ed25519 v1.0.3
  Downloaded getrandom v0.2.2
  Downloaded lock_api v0.3.4
  Downloaded cfg-if v1.0.0
  Downloaded ansi_term v0.11.0
  Downloaded addr2line v0.14.1
  Downloaded pnet_macros v0.29.0
  Downloaded pnet_datalink v0.29.0
  Downloaded hex v0.4.2
  Downloaded glob v0.3.0
  Downloaded data-encoding v2.3.2
  Downloaded slog-term v2.8.0
  Downloaded num_cpus v1.13.1
  Downloaded spin v0.5.2
  Downloaded signature v1.3.0
  Downloaded tempfile v3.2.0
  Downloaded time v0.1.43
  Downloaded unicode-width v0.1.8
  Downloaded thiserror-impl v1.0.23
  Downloaded thiserror v1.0.23
  Downloaded rustc-demangle v0.1.18
  Downloaded lazy_static v1.4.0
  Downloaded strsim v0.8.0
  Downloaded smallvec v1.6.1
  Downloaded bitflags v1.2.1
  Downloaded pnet_macros_support v0.29.0
  Downloaded rand_chacha v0.3.0
  Downloaded lock_api v0.4.2
  Downloaded scopeguard v1.1.0
  Downloaded same-file v1.0.6
  Downloaded ppv-lite86 v0.2.10
  Downloaded signal-hook-registry v1.4.0
  Downloaded parking_lot_core v0.8.2
  Downloaded pin-project-lite v0.2.8
  Downloaded parking_lot v0.11.1
  Downloaded thread_local v1.1.2
  Downloaded pnet_transport v0.29.0
  Downloaded pnet v0.29.0
  Downloaded parking_lot_core v0.7.2
  Downloaded anyhow v1.0.41
  Downloaded rand_core v0.6.1
  Downloaded proc-macro2 v1.0.50
  Downloaded term v0.7.0
  Downloaded unicode-ident v1.0.6
  Downloaded slog v2.7.0
  Downloaded num-integer v0.1.44
  Downloaded quote v1.0.23
  Downloaded parking_lot v0.10.2
  Downloaded remove_dir_all v0.5.3
  Downloaded log v0.4.14
  Downloaded base64 v0.12.3
  Downloaded pnet_packet v0.29.0
  Downloaded heck v0.3.2
  Downloaded cc v1.0.66
  Downloaded serde_derive v1.0.123
  Downloaded indexmap v1.6.1
  Downloaded once_cell v1.5.2
  Downloaded num-traits v0.2.14
  Downloaded bytes v1.1.0
  Downloaded hashbrown v0.9.1
  Downloaded ryu v1.0.5
  Downloaded memchr v2.4.1
  Downloaded toml v0.5.8
  Downloaded backtrace v0.3.56
  Downloaded miniz_oxide v0.4.3
  Downloaded rand v0.8.3
  Downloaded serde v1.0.123
  Downloaded mio v0.7.14
  Downloaded aho-corasick v0.7.18
  Downloaded serde_json v1.0.61
  Downloaded unicode-segmentation v1.7.1
  Downloaded chrono v0.4.19
  Downloaded cbindgen v0.16.0
  Downloaded clap v2.33.3
  Downloaded object v0.23.0
  Downloaded syn v1.0.107
  Downloaded regex-syntax v0.6.28
  Downloaded regex v1.7.1
  Downloaded tokio v1.16.1
  Downloaded libc v0.2.139
  Downloaded gimli v0.23.0
  Downloaded ring v0.16.20
  Downloaded 101 crates (11.2 MB) in 13.71s (largest was `ring` at 5.1 MB)
   Compiling libc v0.2.139
   Compiling proc-macro2 v1.0.50
   Compiling autocfg v1.0.1
   Compiling unicode-ident v1.0.6
   Compiling quote v1.0.23
   Compiling syn v1.0.107
   Compiling serde v1.0.123
   Compiling serde_derive v1.0.123
   Compiling cfg-if v1.0.0
   Compiling memchr v2.4.1
   Compiling cc v1.0.66
   Compiling bitflags v1.2.1
   Compiling getrandom v0.2.2
   Compiling log v0.4.14
   Compiling miniz_oxide v0.4.3
   Compiling smallvec v1.6.1
   Compiling same-file v1.0.6
   Compiling scopeguard v1.1.0
   Compiling walkdir v2.3.1
   Compiling rand_core v0.6.1
   Compiling num-traits v0.2.14
   Compiling pkg-config v0.3.19
   Compiling anyhow v1.0.41
   Compiling ryu v1.0.5
   Compiling ppv-lite86 v0.2.10
   Compiling aho-corasick v0.7.18
   Compiling indexmap v1.6.1
   Compiling num-integer v0.1.44
   Compiling rand_chacha v0.3.0
   Compiling regex-syntax v0.6.28
   Compiling once_cell v1.5.2
   Compiling serde_json v1.0.61
   Compiling adler v0.2.3
   Compiling libsodium-sys v0.2.6 (https://github.com/cjdelisle/sodiumoxide?rev=9f6a18d40a4db253edfebac9f2ce5c22d09b1f47#9f6a18d4)
   Compiling unicode-width v0.1.8
   Compiling pnet_base v0.29.0
   Compiling gimli v0.23.0
   Compiling textwrap v0.11.0
   Compiling rand v0.8.3
   Compiling atty v0.2.14
   Compiling dirs-sys-next v0.1.2
   Compiling instant v0.1.9
   Compiling slog v2.7.0
   Compiling strsim v0.8.0
   Compiling regex v1.7.1
   Compiling signature v1.3.0
   Compiling itoa v0.4.7
   Compiling vec_map v0.8.2
   Compiling ansi_term v0.11.0
   Compiling addr2line v0.14.1
   Compiling cbindgen v0.16.0
   Compiling remove_dir_all v0.5.3
   Compiling object v0.23.0
   Compiling rustc-demangle v0.1.18
   Compiling unicode-segmentation v1.7.1
   Compiling hashbrown v0.9.1
   Compiling heck v0.3.2
   Compiling tempfile v3.2.0
   Compiling clap v2.33.3
   Compiling ed25519 v1.0.3
   Compiling parking_lot_core v0.8.2
   Compiling dirs-next v2.0.0
   Compiling backtrace v0.3.56
   Compiling pnet_macros_support v0.29.0
   Compiling ring v0.16.20
   Compiling time v0.1.43
   Compiling pnet_sys v0.29.0
   Compiling lock_api v0.4.2
   Compiling cfg-if v0.1.10
   Compiling parking_lot_core v0.7.2
   Compiling parking_lot v0.11.1
   Compiling chrono v0.4.19
   Compiling pnet_macros v0.29.0
   Compiling thiserror-impl v1.0.23
   Compiling term v0.7.0
   Compiling pnet_packet v0.29.0
   Compiling thread_local v1.1.2
   Compiling lock_api v0.3.4
   Compiling hex v0.4.2
   Compiling boxfnonce v0.1.1
   Compiling spin v0.5.2
   Compiling untrusted v0.7.1
   Compiling pnet v0.29.0
   Compiling toml v0.5.8
   Compiling ipnetwork v0.18.0
   Compiling pnet_datalink v0.29.0
   Compiling pnet_transport v0.29.0
   Compiling daemonize v0.4.1
   Compiling parking_lot v0.10.2
   Compiling slog-term v2.8.0
   Compiling thiserror v1.0.23
   Compiling tokio-macros v1.7.0
   Compiling mio v0.7.14
   Compiling signal-hook-registry v1.4.0
   Compiling num_cpus v1.13.1
   Compiling lazy_static v1.4.0
   Compiling data-encoding v2.3.2
   Compiling pin-project-lite v0.2.8
   Compiling base64 v0.12.3
   Compiling bytes v1.1.0
   Compiling boringtun v0.3.0 (https://github.com/cjdelisle/boringtun?rev=f288b2f461e7322a278b63b1ddc4ab705b5b7462#f288b2f4)
   Compiling cjdns_sys v0.1.0 (/home/marek/cjdns/rust/cjdns_sys)
   Compiling tokio v1.16.1
   Compiling sodiumoxide v0.2.6 (https://github.com/cjdelisle/sodiumoxide?rev=9f6a18d40a4db253edfebac9f2ce5c22d09b1f47#9f6a18d4)
   Compiling cjdns-crypto v0.1.0 (https://github.com/CJDNS-Development-Team/CJDNS#46c9c1b6)
   Compiling cjdns-keys v0.1.0 (https://github.com/CJDNS-Development-Team/CJDNS#46c9c1b6)
warning: variable does not need to be mutable
   --> rust/cjdns_sys/src/interface/wire/message.rs:354:17
    |
354 |             let mut msg = &mut (*self.msg);
    |                 ----^^^
    |                 |
    |                 help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

warning: `cjdns_sys` (lib) generated 1 warning (run `cargo fix --lib -p cjdns_sys` to apply 1 suggestion)
    Finished release [optimized] target(s) in 1m 58s
warning: the following packages contain code that will be rejected by a future version of Rust: boringtun v0.3.0 (https://github.com/cjdelisle/boringtun?rev=f288b2f461e7322a278b63b1ddc4ab705b5b7462#f288b2f4), daemonize v0.4.1
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
Running test Beacon_noisenoise_test                                                3.766 ms
Running test Beacon_noiseold_test                                                  1.880 ms
Running test Beacon_oldnoise_test                                                  1.788 ms
Running test Beacon_oldold_test                                                    2.991 ms
Running test CryptoAddress_test                                                    0.29 ms
Running test printIp_test                                                          1.748 ms
Running test CryptoAuth_randnonce_test                                             0.7 ms
Running test CryptoAuth_test                                                       21.709 ms
Running test CryptoAuth_unit_test                                                  1.784 ms
Running test ReplayProtector_test                                                  0.65 ms
Running test Sign_test                                                             0.282 ms
Running test RustIface_test                                                        0.10 ms
Running test FileReader_test                                                       0.143 ms
Running test Allocator_test                                                        0.3 ms
Running test LinkState_test                                                        1.83 ms
Running test EncodingScheme_test                                                   16.612 ms
Running test LabelSplicer_test                                                     0.11 ms
Running test NumberCompress_test                                                   0.954 ms
Running test IpTunnel_test                                                         0.681 ms
Running test RouteGen_test                                                         4.408 ms
Running test AddrTools_test                                                        0.4 ms
Running test AverageRoller_test                                                    0.16 ms
Running test Base10_test                                                           0.251 ms
Running test Base32_test                                                           0.19 ms
Running test Bits_test                                                             0.73 ms
Running test Checksum_test                                                         0.3 ms
Running test Endian_test                                                           0.1 ms
Running test Hex_test                                                              0.18 ms
Running test Identity_test                                                         0.1 ms
Running test Map_test                                                              3.666 ms
Running test Process_test                                                          1.279 ms
Running test QSort_test                                                            0.6 ms
Running test Seccomp_test                                                          0.914 ms
Running test Set_testthread 'main' panicked at 'Disallowed Syscall', rust/cjdns_sys/src/rffi.rs:348:5
                                                              27.613 ms
Running test UniqueName_test                                                       0.6 ms
Running test VarInt_test                                                           0.67 ms
Running test Version_test                                                          0.1 ms
Running test Random_test                                                           0.458 ms
Running test BSDMessageTypeWrapper_test                                            0.3 ms
Running test TAPWrapper_root_test
Root test TAPWrapper_root_test disabled, use [./target/release/testcjdroute TAPWrapper_root_test +roottest] to include it
                                                  0.2 ms
Running test TUNInterface_ipv4_root_test
Root test TUNInterface_ipv4_root_test disabled, use [./target/release/testcjdroute TUNInterface_ipv4_root_test +roottest] to include it
                                           0.2 ms
Running test TUNInterface_ipv6_root_test
Root test TUNInterface_ipv6_root_test disabled, use [./target/release/testcjdroute TUNInterface_ipv6_root_test +roottest] to include it
                                           0.2 ms
Running test TUNInterface_ipv6_withroute_root_test
Root test TUNInterface_ipv6_withroute_root_test disabled, use [./target/release/testcjdroute TUNInterface_ipv6_withroute_root_test +roottest] to include it
                                 0.2 ms
Running test Sockaddr_test                                                         0.16 ms
Running test TAPDevice_root_test                                                   0.1 ms
Running test TAPInterface_root_test                                                0.1 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cCtrlAddrErr 5.219 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/crypto_test_CryptoAuthFuzz_noise_fuzz_test_cDefault 0.477 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/crypto_test_CryptoAuthFuzz_old_fuzz_test_cDefault 0.460 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/crypto_test_CryptoAuthFuzz_oldnew_fuzz_test_cDefault 1.219 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/interface_test_FramingIface_fuzz_test_cDefault 0.49 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/util_test_Map_fuzz_test_cDefault 0.10 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/benc_serialization_json_test_JsonBencMessageReader_fuzz_test_cConfFile 0.25 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cCtrlAuthErr 14.675 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cCtrlPing 33.502 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cCtrlPong 6.346 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cCtrlUndeliverable 8.461 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cDhtFindNodeQuery 12.178 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cDhtGetPeersQuery 3.568 ms
Running fuzz /home/marek/cjdns/target/release/build/cjdns_sys-0021e197d55ab164/out/fuzz_inputs/test_Main_fuzz_test_cDhtPingQuery 7.775 ms
Total test time 188.370 ms
\x1b[1;32mBuild completed successfully, type ./cjdroute to begin setup.\x1b[0m