Fix map loop - Githubissues

hyperboria / bugs

Peer-to-peer IPv6 networking, secure and near-zero-conf.

154 stars 17 forks source link

Fix map loop #91

Closed wfleurant closed 8 years ago

ghost commented 8 years ago

What's this about?

wfleurant commented 8 years ago

We aught to test this PR here -- The first half of this PR was reverted but @madafoo added tests & fixes on request. @Kubuxu mentions map optimizations.

https://github.com/cjdelisle/cjdns/pull/890 https://github.com/cjdelisle/cjdns/pull/889

Kubuxu commented 8 years ago

@wfleurant why are you PRing someone's work branch? When he is done he will PR this himself (if I am not missing here anything).

wfleurant commented 8 years ago

cjd reverted the first PR.. had asked madafoo for

[x] bugfix
[x] testcase
[x] works

i'm not expecting additional fixes from his branch. i think we should accept this PR because i'm the only one (afaik) who has tested it for hangs after the bugfixens.. wdyt?

wfleurant commented 8 years ago

We can nix this PR. I just pinged madafoo asking to make PR to hyperboria/cjdns :watch:

wfleurant commented 8 years ago

Reasoning for re-opening this issue:

https://github.com/cjdelisle/cjdns/pull/890#issuecomment-169419299
For fucks sake

Ain't this PR an the reason we forked into [hyperboria/cjdns] in the first place?

Kubuxu commented 8 years ago

Have you addressed long test issue?

hyperboria/cjdns is supposed to be merged into cjdelisle.