search

hyperbrowser / genomic-hyperbrowser

The GSuite HyperBrowser - the new version of the Genomic HyperBrowser, currently forked from Galaxy v16.01
https://hyperbrowser.uio.no
Other
2 stars 2 forks source link

Review/add tests for new file formats in HB #127

Open sveinugu opened 4 years ago

sveinugu commented 4 years ago
sveinugu commented 4 years ago

Including common bounding issues such as empty files

radmilak commented 4 years ago

@sveinugu There is one issue that we never really resolved - it is long ago so I don't remember the exact details, but it has something to do with the possibility of having two bounding region without a space right behind each other. I think in some of the other formats this isn't possible though the new formats are parsed in a different way so the situation is a bit different there.. I think we discussed this and came to the fact that perhaps this is not a problem, also I think implementing this for at least one or several of these new formats was somehow not-trivial, though I can't remember exactly why. I guess we perhaps don't have the time to resolve this now, or what do you think?

radmilak commented 3 years ago

The tests and also the rest of the file format support is here: https://github.com/hyperbrowser/genomic-hyperbrowser/tree/ft_master/new_fileformats_support. A remaining issue is the bounding regions solution mentioned in my previous comment.