hypercerts-org / hypercerts

Hypercerts are a tool to build scalable retrospective reward systems for impact.
https://hypercerts.org/
Other
92 stars 29 forks source link

[SDK] Metadata not uploaded to IPFS consistently #940

Open bitbeckers opened 1 year ago

bitbeckers commented 1 year ago

Which area(s) of Hypercerts are affected? (leave empty if unsure)

SDK

To Reproduce

Review the hypercerts I've created: https://testnets.opensea.io/0x1C9F765C579F94f6502aCd9fc356171d85a1F8D0?search[sortAscending]=false&search[sortBy]=CREATED_DATE

Some have URIs that render on OpenSea, others don't: 159592430085920139364322690885499291172867: bafybeia2jw3oik5sp6l5rfvs54tgi3hylqvfl3igjtm3twc5kroz6hoaeq 158571582985157323973932567063203986538497: bafybeieba7srhdynfgy5qidrc4jiwdgp4p2c4c5jykhougstfaeqv3roqe

Describe the Bug

Some metadata is parsed and rendered by OpenSea, some isn't. They do render in the dApp

Expected Behavior

All hypercert metadata should render

ryscheng commented 1 year ago

This is.... weird!

I see the image is in the metadata, and I'm able to open those data URL links manually in my browser. So opensea has issues with some image URLs?

bitbeckers commented 1 year ago

OpenSea is very strict in their parsing. Some missing value or an empty [] and they just don't show the metadata. We might be more lenient and know what we expect. So my strategy will be comparing metadatasets and finding the differences

bitbeckers commented 1 year ago

Been inspecting the metadata and the only difference thus far is the "external_url" being present or not:

benedictvscriticus commented 12 months ago

@bitbeckers can you give me some more context for this please?