search

hypercore-protocol / cli

A CLI for peer-to-peer file sharing using the Hypercore Protocol.
MIT License
206 stars 17 forks source link

add closing / to the returned hash-url #45

Closed ghost closed 3 years ago

ghost commented 3 years ago
  1. for consistency, most(?) places, including beaker address bar, print/show hash-url with closing /, i.e.
> hyp sync ./ `cat ./.hyper` -y
Source: ./
Target: hyper://4fe8d269555b9dbf639ec1c60f1860a5528f78ae9f10d14fe7d9c73796037ab2/
Syncing...
4fe8d2..b2: Announced to seed
Synced
  1. visual insurance too – people copy-pasting it will be certain they got the entire url, and not just the first n-1 letters of the hash

regexps parsing the output were likely only looking for hyper://\w+

pfrazee commented 3 years ago

LGTM

pfrazee commented 3 years ago

Published 1.5.1