search

hypercore-protocol / cli

A CLI for peer-to-peer file sharing using the Hypercore Protocol.
MIT License
206 stars 17 forks source link

Allow spawned daemon processes to remain running #57

Open specious opened 2 years ago

specious commented 2 years ago

I'm slightly perplexed as to how this used to work, but testing either way shows that the daemon processes spawned by hyp daemon start have a tendency to terminate if they are launched without disconnecting their stdio from the parent process.

OskarRubensson commented 2 years ago

This fix works and without it the CLI-tool doesn't work. A new release with this included would be nice.

davetapley commented 2 years ago

What's the easiest way to test this locally? 🤔

OskarRubensson commented 2 years ago

What's the easiest way to test this locally? 🤔

Pull this fork to test the fix locally: https://github.com/specious/cli/tree/fix/daemon-start

specious commented 2 years ago

What's the easiest way to test this locally? 🤔

I pull PR's into a branch to test them like this:

git fetch origin pull/57/head:pr-57
git checkout pr-57
pcfreak30 commented 2 years ago

Please get this merged in. It's giving me headaches :sweat_smile.

specious commented 2 years ago

@mafintosh, could you please take a quick look at this?

specious commented 2 years ago

@pfrazee, no doubt you are busy, but all you need to do is merge and push to npm.

specious commented 2 years ago

@andrewosh, maybe you could take a quick look?

mafintosh commented 2 years ago

@specious hi! we've been focused on making the latest hypercore and hyperdrive (see the -next repos). i suggest you take a look at those. we'll be deprecating the deamon when those land, as they allow for much easier "embedded" workflows so you don't need a daemon at all which is nice.

suggest you join the discord if you wanna know more :)

specious commented 2 years ago

That's quite exciting, but merging this pull request would fix the version that people are currently trying to use.

ralphtheninja commented 2 years ago

@mafintosh Can we get this merged and published as a patch? I'm installing this globally with npm i @hyperspace/cli -g and manually editing this file to make it work. I realize you are working on more important things that will be coming out, but there are people relying on this to make it work on node 16.

originalmk commented 2 years ago

@ralphtheninja Same. I came across this project today and I wanted to give it a try. NodeJS LTS installed, everything fine... but what... it does not work! Would really appreciate if this was merged.

specious commented 2 years ago

For the time being, we can install it directly from this pull request:

npm i -g hypercore-protocol/cli#pull/57/head
ralphtheninja commented 2 years ago

For the time being, we can install it directly from this pull request:

I had no clue you could do this. Very nice!