hypercore-protocol / hyperdrive-daemon

Hyperdrive, batteries included.
MIT License
156 stars 24 forks source link

Update README with fs key subcommand #26

Closed edrex closed 4 years ago

edrex commented 4 years ago

Hopefully I caught them all.

Additionally, I found these lines confusing and would like to clarify them before merging:

Newly-created drives are private by default, and can be made available to the network with hyperdrive fs publish .

key is an optional drive key. If key is specified, it will be advertised on the network by default, and your drive will be read-only.

I think the first only applies to locally-created drives (mounted without <key>), right?

The second seems to indicate that anyone on the network will be able to access the drive, but I believe they won't without the discopub key, yes?

andrewosh commented 4 years ago

@edrex Yeah I can see the confusion there. If you mount a read-only drive (a drive that was created by someone else) using fs mount (path) (key), then the daemon will currently advertise that drive on the network by default (reseed by default).

If the drive is writable, so you created it, then you have to manually fs publish (path) the drive to advertise it.

And thanks for the fs key docs! Everything looks great here