hypercore-protocol / hyperdrive-daemon

Hyperdrive, batteries included.
MIT License
156 stars 24 forks source link

Updated fuse-setup.js to log correctly when FUSE installation fails #48

Closed reaktivo closed 4 years ago

reaktivo commented 4 years ago

Hi, I've been trying to get the Hyperdrive Fuse setup to work, but I haven't been successful. I did noticed some small issue when debugging, in that the onerror method is not defined.

reaktivo commented 4 years ago

@andrewosh Wow that was fast!

andrewosh commented 4 years ago

Published in 1.13.8 -- yeah want those errors to be clear! :)

Thanks a bunch for submitting this.

andrewosh commented 4 years ago

And also are you using Windows or Node 14? Those are the only things that are known to cause FUSE problems currently. If you're on Linux or OSX and Node 11, 12, or 13, then this setup failure might be a new issue for us, so any info you have would help.

reaktivo commented 4 years ago

@andrewosh Thanks for the heads up, I had been trying it with Node 10 on macOS and on Node 14 on Ubuntu 20. I'll switch both to Node 12.

I was about to ask @mafintosh, @pfrazee and you if you would be open to have hyperdrive be compatible with Node 10, if you you think it's an achievable goal and if you're open to contributions for it.

Is there any clue what's currently causing the issues on Node 14?

andrewosh commented 4 years ago

So the Node 14 issue is being tracked in #47. We're digging into that one today.

As for 10, it'd be a very straightforward change, but it'd touch all the CLI commands. I made the mistake of writing them with static class properties, which I didn't realize were unsupported in 10.

I'd figured since 10 is about to go into "Maintenance" LTS in a few days, people would be upgrading, but that might be wishful thinking. Totally open to the change.