search

hyperdashio / hyperdash-sdk-py

Official Python SDK for Hyperdash
https://hyperdash.io
199 stars 26 forks source link

bugfix for when 'hyperdash' is used from shell on python>=3.3 without… #75

Closed fgolemo closed 7 years ago

fgolemo commented 7 years ago

Since Python 3.3 the subparsers are optional by default. Therefore if you use hyperdash on the shell without any parameters under Python>=3.3, you get a nasty exception.

This is a known problem with Python. Solution was taken from here: https://bugs.python.org/issue9253

richardartoul commented 7 years ago

Looks good! Let me just figure out why C.I isn't running for your P.R

richardartoul commented 7 years ago

Cool I managed to test it by creating my own pr: #76

I'll merge this one though so you get the credit :)

Thanks for the contribution and please reach out to us with any concerns / questions / suggestions.

Cheers, Richie

fgolemo commented 7 years ago

Cool, did you find out why Travis didn't run?

richardartoul commented 7 years ago

@fgolemo Yeah, we're using CircleCI and it just turns out they don't support it. We might need to switch to TravisCI